Skip to content

Conversation

richkadel
Copy link
Contributor

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 2, 2021
@rust-log-analyzer

This comment has been minimized.

@richkadel richkadel force-pushed the coverage-docs-update-2021-05 branch from f192430 to 68024ff Compare May 2, 2021 11:01
@rust-log-analyzer

This comment has been minimized.

@richkadel
Copy link
Contributor Author

Note, after this lands, we can then land rust-lang/rustc-dev-guide#1122

@richkadel

This comment has been minimized.

@richkadel richkadel force-pushed the coverage-docs-update-2021-05 branch from 68024ff to 996cd89 Compare May 3, 2021 01:26
@rust-log-analyzer

This comment has been minimized.

@richkadel richkadel force-pushed the coverage-docs-update-2021-05 branch 2 times, most recently from ad4cb52 to a508a12 Compare May 5, 2021 15:02
@richkadel
Copy link
Contributor Author

I updated the no_coverage documentation since the feature gate will now only be implemented at the gate level (see #84871).

@richkadel richkadel force-pushed the coverage-docs-update-2021-05 branch from a508a12 to 8075b28 Compare May 6, 2021 19:22
@tmandry
Copy link
Member

tmandry commented May 6, 2021

@bors r+

@bors
Copy link
Collaborator

bors commented May 6, 2021

📌 Commit 8075b28 has been approved by tmandry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 6, 2021
@tmandry
Copy link
Member

tmandry commented May 6, 2021

@bors rollup

bors added a commit to rust-lang-ci/rust that referenced this pull request May 7, 2021
Rollup of 9 pull requests

Successful merges:

 - rust-lang#84779 (Add support for --test-args to cargotest)
 - rust-lang#84781 (Don't check bootstrap artifacts by default)
 - rust-lang#84787 (bump deps)
 - rust-lang#84815 (Update coverage docs and command line help)
 - rust-lang#84875 (Removes unneeded check of `#[no_coverage]` in mapgen)
 - rust-lang#84897 (Coverage instruments closure bodies in macros (not the macro body))
 - rust-lang#84911 (Retry clang+llvm download)
 - rust-lang#84972 (CTFE inbounds-error-messages tweak)
 - rust-lang#84990 (Sort rustdoc-gui tests)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 283ef86 into rust-lang:master May 7, 2021
@rustbot rustbot added this to the 1.54.0 milestone May 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants